RFR: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop [v2]

Erik Österlund eosterlund at openjdk.java.net
Mon Nov 2 17:56:07 UTC 2020


On Mon, 2 Nov 2020 16:19:59 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Coleen CR1: Refactoring
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1570:
> 
>> 1568:   // return a flag when a method terminates by throwing an exception
>> 1569:   // i.e. if an exception is thrown and it's not caught by the current method
>> 1570:   bool exception_exit = state->is_exception_detected() && !state->is_exception_caught();
> 
> So this only applies to the case where the post_method_exit comes from remove_activation?  Good to have it only on this path in this case.

I'm not sure. There might be other cases, when remove_activation is called by the exception code. That's why I didn't want to change it to just true in this path.

-------------

PR: https://git.openjdk.java.net/jdk/pull/930


More information about the hotspot-dev mailing list