RFR: 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic [v4]

[Dong Bo]

On Tue, 3 Nov 2020 10:17:23 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Dong Bo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into aarch64-base64-encoding
>>  - reconstructed the macro as function generate_base64_encode_simdround
>>  - change register name sp and unpack the macro
>>  - Merge branch 'master' into aarch64-base64-encoding
>>  - 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5483:
> 
>> 5481:     Register codec  = rscratch1;
>> 5482:     Register length = rscratch2;
>> 5483: 
> 
> Alias names for scratch registers have proved to be risky because assembler macros use scratch registers freely. A maintenance programmer might not to see this code uses rscratch1 and 2. Given that c_rarg6 and 7 are free, please use them.

Done, I didn't realize this would be a problem at all.
Thanks for the clarification.

-------------

PR: https://git.openjdk.java.net/jdk/pull/992