RFR: 8252848: Optimize small primitive arrayCopy operations through partial inlining using AVX-512 masked instructions [v9]

Vladimir Kozlov kvn at openjdk.java.net
Tue Nov 3 19:00:59 UTC 2020


On Fri, 23 Oct 2020 12:01:11 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 826:
>> 
>>> 824: class VectorMaskGenNode : public TypeNode {
>>> 825:  public:
>>> 826:   VectorMaskGenNode(Node* src, const Type* ty, const Type* ety): TypeNode(ty, 2), _elemType(ety) {
>> 
>> Sorry, I don't quite understand the arguments here. What does 'src' mean to the mask?
>
> ty   -> Node type , long in this case since for X86 mask register is 64 bit wide.
> ety -> Mask element type, currently used during LoadVectorMasked/StoreVectorMasked idealization to compute the block sizes for constant masks and replace masked vector operations with non-masked if block size is equal to vector size. Src has been replaced by a better name "length" used for mask computation.

Please, use meaningful names.

-------------

PR: https://git.openjdk.java.net/jdk/pull/302


More information about the hotspot-dev mailing list