RFR: 8253742: POSIX signal code cleanup [v2]

[Gerard Ziemski]

On Mon, 2 Nov 2020 19:59:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert JVM_handle_XXX_signal change
>
> src/hotspot/os/posix/signals_posix.cpp line 452:
> 
>> 450: }
>> 451: 
>> 452: // Renamed from 'signalHandler' to avoid collision with other shared libs.
> 
> Please don't change those, nor javaSignalHandler().

Reverted.

> src/hotspot/os/posix/signals_posix.cpp line 1261:
> 
>> 1259:   PosixSignals::print_signal_handler(st, SHUTDOWN3_SIGNAL , buf, buflen);
>> 1260:   PosixSignals::print_signal_handler(st, BREAK_SIGNAL, buf, buflen);
>> 1261: #if defined(AIX)
> 
> Can you change both #ifdefs to: `#ifdef SIGDANGER` resp. `#ifdef SIGTRAP` please? Some other Unices have this too.
> 
> (Side note, I always wanted to change this coding to a loop to print all signal handlers unconditionally, regardless of whether this is a "hotspot signal" or not. Since when analyzing customer problems, sometimes its interesting to know if other handlers are installed too(eg SIGCHILD). At least that's how we do things in our propietary VM.)

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636