RFR: 8253742: POSIX signal code cleanup [v3]

[Gerard Ziemski]

On Mon, 2 Nov 2020 19:55:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - use ifdef(SIGDANGER) and ifdef(SIGTRAP)
>>  - revert unblock_program_error_signals change
>
> src/hotspot/os/aix/os_aix.cpp line 1442:
> 
>> 1440: }
>> 1441: 
>> 1442: void os::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
> 
> This makes sense. But then, it would make sense to move this to os_posix.cpp completely. Or to even completely replace calls to os::print_signal_handlers with PosixSignals::print_signal_handlers() and remove the former.

print_signal_handlers() is declared in os.h, so at first glance I thought I couldn't collapse it further. I'll have a second look.

> src/hotspot/share/runtime/os.hpp line 970:
> 
>> 968: 
>> 969:   static address ucontext_get_pc(const ucontext_t* ctx);
>> 970:   static void    ucontext_set_pc(ucontext_t* ctx, address pc);
> 
> This feels misplaced here (and probably won't compile on windows) since ucontext_t is POSIX. At the very least needs ucontext.h. But I would consider moving this to os_posix.

I thought I tested it and it built fine on Windows - will take another look...

-------------

PR: https://git.openjdk.java.net/jdk/pull/636