RFR: 8253742: POSIX signal code cleanup [v3]

[Thomas Stuefe]

On Wed, 4 Nov 2020 04:25:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - use ifdef(SIGDANGER) and ifdef(SIGTRAP)
>>  - revert unblock_program_error_signals change
>
> Hi Gerard,
> 
> Overall looking good. Some changes still to be finalized e.g ucontext_t related functions in os.hpp.
> 
> I flagged some os functions that are implemented in os_foo.cpp but which just call the Posix helper, which can be deleted from os_foo.cpp and simply added to os_posix.cpp. That can't be a further cleanup RFE if you want to limit changes in this PR.
> 
> A few minor nits below.
> 
> Thanks,
> David

> The snapshot of JDK that I'm using in my PR does not build on Windows. Do you have any suggestion how I can safely update to the latest JDK without messing up my PR?

Hi Gerard,

merging master would not help you with the build error. As I said, it complains about ucontext_t. 

As for your question, just do a 

git checkout yourbranch
git merge master

if you get conflicts, you'll need to resolve them, but this is the way to go without invalidating old commits.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636