RFR: JDK-8255711: Fix and unify hotspot signal handlers [v2]

Thomas Stuefe stuefe at openjdk.java.net
Wed Nov 4 14:40:56 UTC 2020


On Wed, 4 Nov 2020 05:48:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary call-once guard from PosixSignals::install_signal_handlers()
>
> src/hotspot/os/posix/signals_posix.cpp line 443:
> 
>> 441: extern "C" JNIEXPORT int
>> 442: #if defined(BSD)
>> 443:                          JVM_handle_bsd_signal
> 
> Can we define this using token pasting e.g.
> 
> PASTE_TOKENS(JVM_handle, PASTE_TOKENS(INCLUDE_SUFFIX_OS, _signal))
> 
> ?

I find that actually less readable than what we have now. Plus, right now its easier to grep for the function name.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1034


More information about the hotspot-dev mailing list