RFR: JDK-8255711: Fix and unify hotspot signal handlers [v3]

[Thomas Stuefe]

On Wed, 4 Nov 2020 23:28:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback David
>
> src/hotspot/os/posix/signals_posix.cpp line 615:
> 
>> 613:           "\n#    /--------------------\\"
>> 614:           "\n#    |      %-7s       |"
>> 615:           "\n#    \\---\\ /--------------/"
> 
> Isn't the little robot supposed to say "segmentation fault" and would that be safer than calling get_signal_name in this context?  thanks for keeping the picture.

Thanks Coleen. Little robot now spells out the name of the signal (since "segmentation fault" is only correct for segv, and I wanted to see it for the other cases too. get_signal_name() is completely harmless, just uses a bit of stack buffer (and that only for the case of unknown signals which are printed numerically; I plan to change that and give us a simple version which just returns static strings).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1034