RFR: 8255553: [PPC64] Introduce and use setbc and setnbc P10 instructions [v6]

Ziviani github.com+670087+jrziviani at openjdk.java.net
Thu Nov 5 12:34:56 UTC 2020


On Thu, 5 Nov 2020 10:50:10 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Ziviani has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> src/hotspot/cpu/ppc/ppc.ad line 11422:
> 
>> 11420: 
>> 11421: // Manifest a CmpL3 result in an integer register.
>> 11422: instruct cmpL3_reg_reg(iRegIdst dst, iRegLsrc src1, iRegLsrc src2) %{
> 
> I had forgotten one detail in my previous review. Sorry for that. We need to model the CR0 effect:
> instruct cmpL3_reg_reg(iRegIdst dst, iRegLsrc src1, iRegLsrc src2, flagsRegCR0 cr0) %{
>   match(Set dst (CmpL3 src1 src2));
>   effect(KILL cr0);
> (Same for other nodes.)

Wow, thanks for catching it. But, let me make my naive question: why is it necessary?

-------------

PR: https://git.openjdk.java.net/jdk/pull/907


More information about the hotspot-dev mailing list