RFR: 8253742: POSIX signal code cleanup [v3]

[Gerard Ziemski]

On Wed, 4 Nov 2020 04:18:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - use ifdef(SIGDANGER) and ifdef(SIGTRAP)
>>  - revert unblock_program_error_signals change
>
> src/hotspot/os/posix/signals_posix.cpp line 1349:
> 
>> 1347:     sigaddset(&unblocked_sigs, SIGTRAP);
>> 1348:   #endif
>> 1349:   sigaddset(&unblocked_sigs, PosixSignals::SR_signum);
> 
> Shouldn't need the PosixSignals::prefix in this method

Here we are going from:
`void PosixSignals::signal_sets_init()`
to
` void signal_sets_init()`
so in this case we do need it.

> src/hotspot/os/posix/signals_posix.cpp line 1286:
> 
>> 1284: void PosixSignals::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
>> 1285:   st->print_cr("Signal Handlers:");
>> 1286:   PosixSignals::print_signal_handler(st, SIGSEGV, buf, buflen);
> 
> You shouldn't need the PosixSignals:: prefix in this method.

Goo catch, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636