RFR: 8253742: POSIX signal code cleanup [v5]

Gerard Ziemski gziemski at openjdk.java.net
Fri Nov 6 20:13:11 UTC 2020


On Tue, 3 Nov 2020 21:43:00 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/hotspot/share/runtime/os.hpp line 970:
>> 
>>> 968: 
>>> 969:   static address ucontext_get_pc(const ucontext_t* ctx);
>>> 970:   static void    ucontext_set_pc(ucontext_t* ctx, address pc);
>> 
>> This feels misplaced here (and probably won't compile on windows) since ucontext_t is POSIX. At the very least needs ucontext.h. But I would consider moving this to os_posix.
>
> I thought I tested it and it built fine on Windows - will take another look...

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636


More information about the hotspot-dev mailing list