RFR: 8256052: Remove unused allocation type from fieldInfo [v3]

[Frederic Parain]

On Mon, 9 Nov 2020 16:36:07 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused symbol from vmStruct
>
> Nice cleanup!

Hi Claes,

Thank you for your review, the new version should address the points you raised.

Fred

> src/hotspot/share/classfile/classFileParser.cpp line 1708:
> 
>> 1706: 
>> 1707:     // Remember how many oops we encountered and compute allocation type
>> 1708:     const FieldAllocationType atype = fac->update(is_static, type);
> 
> The returned `FieldAllocationType` is never used at either call-site, so maybe the `update` method can be simplified, too? (It seems all `update` does is increment a per-type counter, so the name is a bit surprising)

Right, I removed the value returned by the `update()` method.

> src/hotspot/share/runtime/vmStructs.cpp line 2261:
> 
>> 2259:   declare_preprocessor_constant("FIELDINFO_TAG_SIZE", FIELDINFO_TAG_SIZE) \
>> 2260:   declare_preprocessor_constant("FIELDINFO_TAG_OFFSET", FIELDINFO_TAG_OFFSET) \
>> 2261:   declare_preprocessor_constant("FIELDINFO_TAG_CONTENDED", FIELDINFO_TAG_CONTENDED) \
> 
> Not sure it's necessary to add this with no usage?

Not necessary, removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1130