RFR: 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic [v4]

Dong Bo dongbo at openjdk.java.net
Tue Nov 10 09:10:02 UTC 2020


On Wed, 4 Nov 2020 01:43:22 GMT, Dong Bo <dongbo at openjdk.org> wrote:

>> Oh, and please make up your mind wether to use "r6" or "c_rarg6". I know they're the same really. With that, this patch is good.
>
> That's great! I think we will walk into much less detours if there is a guidance which contains empirical coding rules in it.
> 
> For this patch,  if we do not need further modifications, could you please press the approval button? Thanks.

Agree with `c_rarg6`, it's better for readers to understand.
In newest version, I have replaced these with c_rarg6/7, that is:
    // c_rarg6 and c_rarg7 are free to use as temps
    Register codec  = c_rarg6;
    Register length = c_rarg7;

Are we good to go?

-------------

PR: https://git.openjdk.java.net/jdk/pull/992


More information about the hotspot-dev mailing list