RFR: 8256050: JVM crashes with -XX:+PrintDeoptimizationDetails [v2]

[Vladimir Ivanov]

On Mon, 9 Nov 2020 21:03:05 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> Looks good. Your call on whether to add the comment I proposed.

Thanks for the reviews, Vladimir and Dan!

> src/hotspot/share/runtime/basicLock.cpp line 34:
> 
>> 32:   markWord mark_word = displaced_header();
>> 33:   if (mark_word.value() != 0) {
>> 34:     bool print_monitor_info = (owner != NULL) && (owner->mark() == markWord::from_pointer((void*)this));
> 
> Could use a comment between L33 and L34:
> // Print monitor info if there's an owning oop and it refers to this BasicLock.

Yes, I'll incorporate the comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1124