RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

Coleen Phillimore coleenp at openjdk.java.net
Tue Nov 10 21:25:06 UTC 2020


On Mon, 9 Nov 2020 16:31:23 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 121:
>> 
>>> 119:                          upcall_info.upcall_method.name, upcall_info.upcall_method.sig,
>>> 120:                          &args, thread);
>>> 121: }
>> 
>> This code shouldn't be in the cpu directory.  This should be in SharedRuntime or in jni.cpp.  It should have a JNI_ENTRY and not transition directly.  I don't know what AttachCurrentThreadAsDaemon does.
>
> Roger that.
> 
> We need the thread state transition though in case we get a random native thread calling us.

yikes.  Does that work?

-------------

PR: https://git.openjdk.java.net/jdk/pull/634


More information about the hotspot-dev mailing list