RFR: JDK-8256258: some missing NULL checks or asserts after CodeCache::find_blob_unsafe

Aleksey Shipilev shade at openjdk.java.net
Thu Nov 12 10:57:55 UTC 2020


On Thu, 12 Nov 2020 09:11:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Most return values of CodeCache::find_blob_unsafe are NULL checked or at least handled by an asserts. However especially on ppc a few are missing and should be added (e.g. in nativeInst_ppc.cpp).

Leftover below? Otherwise I think the change is fine, because the alternative is `NULL`-dereference and (hopefully) SEGV.

hb-subset-plan.lst line 2:

> 1: GRARNN: gr29643 used before defined gr29643 at:
> 2:     0:      L4Z        gr29647=(hb_array_t<unsigned int>).length(gr29643,8)

What's this change?

-------------

Changes requested by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1181


More information about the hotspot-dev mailing list