RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]
Thomas Schatzl
tschatzl at openjdk.java.net
Thu Nov 12 14:09:00 UTC 2020
On Wed, 11 Nov 2020 15:19:05 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> ayang review
>
> A general comment for future PRs: I think it's best to isolate mechanical changes into their own commits; e.g. `HeapRegionManager* _hrm;` -> `HeapRegionManager _hrm;`. Otherwise, a real change, buried in the immense size of diff, might slip through.
Thanks @albertnetymk @iklam @iignatev for your reviews.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1162
More information about the hotspot-dev
mailing list