RFR: 8252848: Optimize small primitive arrayCopy operations through partial inlining using AVX-512 masked instructions [v11]
Jatin Bhateja
jbhateja at openjdk.java.net
Fri Nov 13 05:39:59 UTC 2020
On Wed, 11 Nov 2020 16:09:20 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>>
>> - JDK-8252848: Review comments addressed.
>> - Merge remote-tracking branch 'origin' into JDK-8252848
>> - JDK-8252848 : Replacing generic assembler routine evmovdqu with macro assembly routine calling type specific leaf level assembly functions.
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8252848
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8252848
>> - JDK-8252848 : Review comments resolution.
>> - Merge remote-tracking branch 'upstream' into JDK-8252848
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8252848
>> - Replacing explicit type checks with existing type checking routines
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8252848
>> - ... and 1 more: https://git.openjdk.java.net/jdk/compare/4031cb41...9e85592a
>
> Do you have any tests that exercise the different possible versions?
> - dynamic length with both small and long copies
> - dynamic length that can be proven always less than PartialInliningSize
> - constant size less than PartialInliningSize
>
> Except for these minor comments, and the tests, I am ready to approve.
Hi @neliasso I have resolved your outstanding review comments, it will be helpful if you can regress the patch through your test infrastructure once.
-------------
PR: https://git.openjdk.java.net/jdk/pull/302
More information about the hotspot-dev
mailing list