RFR: 8256380: JDK-8254162 broke 32bit windows build
Jorn Vernee
jvernee at openjdk.java.net
Mon Nov 16 14:29:02 UTC 2020
On Mon, 16 Nov 2020 14:22:39 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Looks good.
>>
>> Interesting. So because we export with extern "C" all other platforms had the name decorations stripped away, and we only notice the mismatch because 32bit windows still has calling convention specific decorations.
>>
>> ..Thomas
>
> @tstuefe This is a but unnerving. I have no objections to the patch, but it seems worrisome that this mismatch was not caught on other platforms. Anyone care digging more deeply into why this is the case?
Since it's a trivial change, I'll integrate this now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1222
More information about the hotspot-dev
mailing list