Integrated: 8256380: JDK-8254162 broke 32bit windows build

Jorn Vernee jvernee at openjdk.java.net
Mon Nov 16 14:29:04 UTC 2020


On Mon, 16 Nov 2020 12:13:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Fix win-32 linker error due to forward declaration and definition signature mismatch.
> 
> FWIW, the altered header is included from nativeLookup.cpp, which uses the function pointer of that function. But, since the signature of the definition [1] is different, and due to name mangling on the particular ABI, the symbols of the declaration in the header and definition are different as well, and things fail to link later.
> 
> Testing: Building Windows-x86 locally, and running jdk_foreign tests.
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/scopedMemoryAccess.cpp#L181

This pull request has now been integrated.

Changeset: b8de2391
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b8de2391
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8256380: JDK-8254162 broke 32bit windows build

Reviewed-by: shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/1222


More information about the hotspot-dev mailing list