RFR: 8253742: POSIX signal code cleanup [v7]

[Gerard Ziemski]

On Mon, 16 Nov 2020 20:34:47 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix missing os::print_signal_handlers on Windows, white space on Linux
>
> src/hotspot/os/posix/signals_posix.cpp line 1724:
> 
>> 1722:   // initialize suspend/resume support - must do this before signal_sets_init()
>> 1723:   if (SR_initialize() != 0) {
>> 1724:     perror("SR_initialize failed");
> 
> perror() is old :) does not make much sense here either since errno could be stale. Could you pls switch this to whatever we do at this point when facing an unrecoverable error (probly vm_exit_initialization or similar)

Fixed, used `vm_exit_during_initialization(err_msg("SR_initialize failed"));`

> src/hotspot/os/posix/signals_posix.cpp line 1393:
> 
>> 1391: }
>> 1392: 
>> 1393: void signal_sets_init() {
> 
> If this is not needed outside this compilation unit, make it pls static.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636