RFR: 8253742: POSIX signal code cleanup [v7]

Gerard Ziemski gziemski at openjdk.java.net
Tue Nov 17 15:50:25 UTC 2020


On Tue, 17 Nov 2020 15:38:55 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> I'm seeing unexpected changes relating to os::fetch_compiled_frame_from_context seemingly due to the "Merge from master".
>> 
>> Otherwise the actual described changes since last commit seem fine.
>> 
>> Once Thomas's last couple of comments are addressed this is done.
>> 
>> Thanks,
>> David
>
>> I'm seeing unexpected changes relating to os::fetch_compiled_frame_from_context seemingly due to the "Merge from master".
>> 
>> Otherwise the actual described changes since last commit seem fine.
>> 
>> Once Thomas's last couple of comments are addressed this is done.
>> 
>> Thanks,
>> David
> 
> The `ucontext_get_pc()` API needs to be in `os::Posix`, not `PosixSignals`, so that change is OK.

Thank you Thomas and David for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636


More information about the hotspot-dev mailing list