RFR: 8253081: G1 fails on stale objects in archived module graph in Open Archive regions [v4]

Ioi Lam iklam at openjdk.java.net
Tue Nov 17 18:09:12 UTC 2020


On Tue, 17 Nov 2020 14:51:23 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - sjohanss review
>>  - Remove code that "activates" dormant objects as now all active objects are reachable via the root object array
>
> src/hotspot/share/memory/heapShared.cpp line 662:
> 
>> 660:     if (!FLAG_IS_DEFAULT(VerifyArchivedFields)) {
>> 661:       // If this -XX:+VerifyArchivedFields is specified on the command-line, do extra
>> 662:       // checks.
> 
> s/this//

I think we can keep the code and change the comments to the following:

    // If VerifyArchivedFields has a non-default value (e.g., specified on the command-line), do
    // more expensive checks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1163


More information about the hotspot-dev mailing list