RFR: 8253081: G1 fails on stale objects in archived module graph in Open Archive regions [v4]

Ioi Lam iklam at openjdk.java.net
Tue Nov 17 18:13:05 UTC 2020


On Tue, 17 Nov 2020 15:55:07 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - sjohanss review
>>  - Remove code that "activates" dormant objects as now all active objects are reachable via the root object array
>
> src/hotspot/share/memory/heapShared.cpp line 334:
> 
>> 332: }
>> 333: 
>> 334: // Returns an objArray that contains all the roots of the archived objects
> 
> It does..?

Oops good catch! This comment should be moved to above `oop HeapShared::get_root(int index, bool clear) {`

-------------

PR: https://git.openjdk.java.net/jdk/pull/1163


More information about the hotspot-dev mailing list