RFR: 8256365: Clean up vtable initialization code [v2]

[Erik Österlund]

On Tue, 17 Nov 2020 21:54:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I was looking through this code because of JDK-8061949 and want to do some minor cleanups.
>> 1. There's a function in the wrong place (is_override)
>> 2. methodHandles that use mh()->is_native(), with extra (),
>> 3. some methods declared with TRAPS, that don't trap
>> 4. some multi-clause conditionals with confusing formatting
>> 5. extra InstanceKlass::cast() casts
>> 6. some useless asserts
>> 7. and potentially a bug with RedefineClasses where the method being added to the vtable may have been redefined in the constraint verification call. (noreg-hard)
>> 
>> Tested with tier1-3.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert RedefineClasses fix and remove InstanceKlass argument from update_inherited_vtable so which klass is clear.

Looks good. Thanks for separating out the bug fix.

-------------

Marked as reviewed by eosterlund (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1236