RFR: 8253742: POSIX signal code cleanup [v9]

[Thomas Stuefe]

On Tue, 17 Nov 2020 22:55:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   last tweaks
>
> src/hotspot/os/posix/signals_posix.cpp line 1721:
> 
>> 1719:   // initialize suspend/resume support - must do this before signal_sets_init()
>> 1720:   if (SR_initialize() != 0) {
>> 1721:     vm_exit_during_initialization("SR_initialize failed");
> 
> You've lost the failure reason (errno) that perror would have provided. SR_initalize only returns non-zero if sigaction fails, which leaves errno set - hence perror() would report it. That said there are only two errors for sigaction (EFAULT or EINVAL) so we really haven't lost anything that useful.
> Arguably the vm_exit... should be inside SR_initialize.
> But I'm fine with this as-is so we can conclude this PR.

Yes, but this relies on knowing the internal implementation of SR_initialize() (mainly that the last CRT call there was sigaction) and is different from all the other places where we do CRT calls. I'd rather add logging right there if the call fails like we do in other places.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636