Integrated: 8256365: Clean up vtable initialization code

[Coleen Phillimore]

On Mon, 16 Nov 2020 20:38:22 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I was looking through this code because of JDK-8061949 and want to do some minor cleanups.
> 1. There's a function in the wrong place (is_override)
> 2. methodHandles that use mh()->is_native(), with extra (),
> 3. some methods declared with TRAPS, that don't trap
> 4. some multi-clause conditionals with confusing formatting
> 5. extra InstanceKlass::cast() casts
> 6. some useless asserts
> 7. and potentially a bug with RedefineClasses where the method being added to the vtable may have been redefined in the constraint verification call. (noreg-hard)
> 
> Tested with tier1-3.

This pull request has now been integrated.

Changeset: fa8dce4f
Author:    Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/fa8dce4f
Stats:     131 lines in 4 files changed: 30 ins; 37 del; 64 mod

8256365: Clean up vtable initialization code

Reviewed-by: eosterlund, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/1236