RFR: 8256640: assert(!m->is_old() || ik()->is_being_redefined()) failed: old methods should not be in vtable

Coleen Phillimore coleenp at openjdk.java.net
Thu Nov 19 21:25:05 UTC 2020


On Thu, 19 Nov 2020 20:42:29 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> src/hotspot/share/oops/klassVtable.cpp line 507:
>> 
>>> 505:         // Set the vtable index before the constraint check safepoint potentially
>>> 506:         // redefines this method, which is possible if it is a default method belonging
>>> 507:         // to a super class or interface.
>> 
>> Minor nit, wording is awkward.  Maybe:
>> Set the vtable index before the constraint check safepoint, which potentially redefines this method if this method is a default method belonging to a super class or interface.
>
> The suggested rewrite reads better.

ok, that wording is more clear. thank you!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1323


More information about the hotspot-dev mailing list