RFR: 8256640: assert(!m->is_old() || ik()->is_being_redefined()) failed: old methods should not be in vtable

[Daniel D.Daugherty]

On Thu, 19 Nov 2020 21:26:55 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/oops/klassVtable.cpp line 237:
>> 
>>> 235:           // needs new entry
>>> 236:           if (needs_new_entry) {
>>> 237:             // Refetch this default method in case of redefinition in safepoint above.
>> 
>> Which code above can go to a safepoint? So perhaps reword the comment:
>> 
>> // Refetch this default method in case of redefinition in a safepoint that
>> // might happen in XXX above.
>
> // Refetch this default method in case of redefinition that might
>             // happen during constraint checking in the update_inherited_vtable call above.
> How about this?

Looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1323