RFR: 8246378: [Windows] assert on MethodHandle logging code [v2]

[Ioi Lam]

On Thu, 19 Nov 2020 21:20:24 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The MethodHandles verbose logging code tries to walk windows stacks without using the StackWalk API and fails miserably.  It was the only consumer of os::current_frame() and get_sender_for_C_frame().  For Windows, the hs_err stack walking was fixed to use the StackWalk API and NMT was used to use RtlCaptureStackBackTrace.
>> This change removes the stub generated for getting the fp (which isn't valid anyway on windows).  I also removed it from windows_aarch64 since it wasn't actually generated.
>> 
>> Tested with tier1-3 for windows-x64.
>> Thanks,
>> Coleen
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   restore fp and sp printing.

LGTM.

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 6720:

> 6718: 
> 6719:     // platform dependent
> 6720:     StubRoutines::x86::_get_previous_sp_entry = generate_get_previous_sp();

The body of `generate_get_previous_fp()` can also be removed.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1321