RFR: 8246378: [Windows] assert on MethodHandle logging code [v3]
Vladimir Ivanov
vlivanov at openjdk.java.net
Fri Nov 20 10:41:04 UTC 2020
On Fri, 20 Nov 2020 00:03:18 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> The MethodHandles verbose logging code tries to walk windows stacks without using the StackWalk API and fails miserably. It was the only consumer of os::current_frame() and get_sender_for_C_frame(). For Windows, the hs_err stack walking was fixed to use the StackWalk API and NMT was used to use RtlCaptureStackBackTrace.
>> This change removes the stub generated for getting the fp (which isn't valid anyway on windows). I also removed it from windows_aarch64 since it wasn't actually generated.
>>
>> Tested with tier1-3 for windows-x64.
>> Thanks,
>> Coleen
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove generate_get_previous_fp().
Looks good.
-------------
Marked as reviewed by vlivanov (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1321
More information about the hotspot-dev
mailing list