Integrated: 8246378: [Windows] assert on MethodHandle logging code

Coleen Phillimore coleenp at openjdk.java.net
Fri Nov 20 13:03:06 UTC 2020


On Thu, 19 Nov 2020 16:09:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> The MethodHandles verbose logging code tries to walk windows stacks without using the StackWalk API and fails miserably.  It was the only consumer of os::current_frame() and get_sender_for_C_frame().  For Windows, the hs_err stack walking was fixed to use the StackWalk API and NMT was used to use RtlCaptureStackBackTrace.
> This change removes the stub generated for getting the fp (which isn't valid anyway on windows).  I also removed it from windows_aarch64 since it wasn't actually generated.
> 
> Tested with tier1-3 for windows-x64.
> Thanks,
> Coleen

This pull request has now been integrated.

Changeset: e7c7469c
Author:    Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/e7c7469c
Stats:     158 lines in 11 files changed: 14 ins; 98 del; 46 mod

8246378: [Windows] assert on MethodHandle logging code

Reviewed-by: iklam, vlivanov

-------------

PR: https://git.openjdk.java.net/jdk/pull/1321


More information about the hotspot-dev mailing list