RFR: JDK-8256725: Metaspace: better blocktree and binlist asserts [v3]

Thomas Stuefe stuefe at openjdk.java.net
Sat Nov 21 09:31:30 UTC 2020


> Hi,
> 
> may I have reviews please for this small change. 
> 
> To analyze JDK-8256572, I'd like to see more information in asserts for binlist and blocktree.
> 
> This patch:
> 
> - beefs up assertion messages when verifying binlist and blocktree
> - adds a canary to the blocktree node to detect overwriters
> - improves the blocktree printing
> - adds a gtest death test to test the overwrite detection.
> 
> Thanks!

Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:

  Quick node checks in blocktree on insert/removal

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1339/files
  - new: https://git.openjdk.java.net/jdk/pull/1339/files/491f9782..4e85fe65

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1339&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1339&range=01-02

  Stats: 30 lines in 2 files changed: 19 ins; 5 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1339.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1339/head:pull/1339

PR: https://git.openjdk.java.net/jdk/pull/1339


More information about the hotspot-dev mailing list