RFR: 8252848: Optimize small primitive arrayCopy operations through partial inlining using AVX-512 masked instructions [v14]

[Vladimir Kozlov]

On Sat, 21 Nov 2020 19:36:54 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Forgot to say that failure was on Windows with only avx512f, avx512cd.
>
>> Forgot to say that failure was on Windows with only avx512f, avx512cd
> 
> Thanks Vladimir, I have resolved your review comments.

Version 15 failed next tests on linux-x64 with  -XX:+UseParallelGC -XX:+UseNUMA flags:
vmTestbase/metaspace/stressHierarchy/stressHierarchy015/TestDescription.java
vmTestbase/metaspace/stressHierarchy/stressHierarchy006/TestDescription.java
vmTestbase/metaspace/stressHierarchy/stressHierarchy005/TestDescription.java

# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/workspace/open/src/hotspot/share/opto/macroArrayCopy.cpp:861), pid=8205, tid=8216
#  assert(ArrayCopyNode::may_modify(dest_t, (*ctrl)->in(0)->as_MemBar(), &_igvn, ac)) failed: dependency on arraycopy lost
#
# Problematic frame:
# V  [libjvm.so+0x134fbfc]  PhaseMacroExpand::generate_arraycopy(ArrayCopyNode*, AllocateArrayNode*, Node**, MergeMemNode*, Node**, TypePtr const*, BasicType, Node*, Node*, Node*, Node*, Node*, bool, bool, RegionNode*)+0x30bc
#
Host:  Intel(R) Xeon(R) Platinum 8167M CPU @ 2.00GHz, 8 cores, 58G, Oracle Linux Server release 7.9

Current CompileTask:
C2:  27392 5458       4       package_level34_num50.Dummy::composeString (10 bytes)

Stack: [0x00007f4c5a024000,0x00007f4c5a125000],  sp=0x00007f4c5a120420,  free space=1009k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0x134fbfc]  PhaseMacroExpand::generate_arraycopy(ArrayCopyNode*, AllocateArrayNode*, Node**, MergeMemNode*, Node**, TypePtr const*, BasicType, Node*, Node*, Node*, Node*, Node*, bool, bool, RegionNode*)+0x30bc
V  [libjvm.so+0x1350741]  PhaseMacroExpand::expand_arraycopy_node(ArrayCopyNode*)+0x641
V  [libjvm.so+0x1340d7b]  PhaseMacroExpand::expand_macro_nodes()+0xfdb
V  [libjvm.so+0x9fe79b]  Compile::Optimize()+0x177b
V  [libjvm.so+0xa00268]  Compile::Compile(ciEnv*, ciMethod*, int, bool, bool, bool, bool, DirectiveSet*)+0x17e8
V  [libjvm.so+0x8322ae]  C2Compiler::compile_method(ciEnv*, ciMethod*, int, bool, DirectiveSet*)+0x1ce
V  [libjvm.so+0xa103f8]  CompileBroker::invoke_compiler_on_method(CompileTask*)+0xe08
V  [libjvm.so+0xa10f48]  CompileBroker::compiler_thread_loop()+0x5a8

-------------

PR: https://git.openjdk.java.net/jdk/pull/302