Integrated: JDK-8256725: Metaspace: better blocktree and binlist asserts

Thomas Stuefe stuefe at openjdk.java.net
Mon Nov 23 18:52:56 UTC 2020


On Fri, 20 Nov 2020 08:34:18 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi,
> 
> may I have reviews please for this small change. 
> 
> To analyze JDK-8256572, I'd like to see more information in asserts for binlist and blocktree.
> 
> This patch:
> 
> - beefs up assertion messages when verifying binlist and blocktree
> - adds a canary to the blocktree node to detect overwriters
> - improves the blocktree printing
> - adds a gtest death test to test the overwrite detection.
> 
> Thanks!

This pull request has now been integrated.

Changeset: fa75ad69
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/fa75ad69
Stats:     175 lines in 5 files changed: 131 ins; 15 del; 29 mod

8256725: Metaspace: better blocktree and binlist asserts

Reviewed-by: shade, rrich, lkorinth

-------------

PR: https://git.openjdk.java.net/jdk/pull/1339


More information about the hotspot-dev mailing list