RFR: JDK-8256922: ppc, ppcle build broken after JDK-8254231

David Holmes dholmes at openjdk.java.net
Tue Nov 24 07:21:55 UTC 2020


On Tue, 24 Nov 2020 06:57:24 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi,
> 
> may I please have reviews for these fixes to the ppc, ppcle builds after JDK-8254231.
> 
> Once the build is fixed, VM does not come up, but that is a separate issue (JDK-8256924).
> 
> This roughly followed Alekseys work on s390, but additionally I had to rename the _abi macro due to name conflict with a class member in the new code.
> 
> Thanks, Thomas

Hi Thomas,

Generally looks okay but two of your new files have s390 in the name instead of ppc.

Cheers,
David

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1404


More information about the hotspot-dev mailing list