RFR: JDK-8256922: ppc, ppcle build broken after JDK-8254231 [v2]

Aleksey Shipilev shade at openjdk.java.net
Tue Nov 24 09:46:56 UTC 2020


On Tue, 24 Nov 2020 08:28:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/frame_ppc.hpp line 121:
>> 
>>> 119:   };
>>> 120: 
>>> 121:   #define _abi0(_component) \
>> 
>> When I was experimenting with this code, I thought to name it consistently with `_abi_reg_args_spill` definition a few lines below. That is, make it `_abi_reg_args`. Does that make more sense than `_abi0`?
>
> Sure, but lets ask @RealLucy @TheRealMDoerr first to agree on a name.

Pardon me, I did not mean to stall this build-fixing integration. `_abi0` is an okay name, at least temporarily. We can rename it properly later.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1404


More information about the hotspot-dev mailing list