RFR: JDK-8256922: ppc, ppcle build broken after JDK-8254231 [v2]

Lutz Schmidt lucy at openjdk.java.net
Tue Nov 24 10:21:58 UTC 2020


On Tue, 24 Nov 2020 07:30:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi,
>> 
>> may I please have reviews for these fixes to the ppc, ppcle builds after JDK-8254231.
>> 
>> Once the build is fixed, VM does not come up, but that is a separate issue (JDK-8256924).
>> 
>> This roughly followed Alekseys work on s390, but additionally I had to rename the _abi macro due to name conflict with a class member in the new code.
>> 
>> Thanks, Thomas
>
> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - include guard misnamed
>  - Rename files

The changes look good to me. 
WRT the macro name (_abi0 or _abi_reg_args), I'm very much in favour of the latter. But that should not stall the build fix integration, as Aleksey notes correctly. Maybe there is a volunteer changing the name in a separate effort.

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1404


More information about the hotspot-dev mailing list