RFR: 8255479: [aarch64] assert(src->section_index_of(target) == CodeBuffer::SECT_NONE) failed: sanity

Nils Eliasson neliasso at openjdk.java.net
Tue Nov 24 14:31:02 UTC 2020


On Mon, 23 Nov 2020 11:53:04 GMT, Patric Hedlin <phedlin at openjdk.org> wrote:

> The "byte map base" (CardTable) might be materialised as an external address but as such the current relocation support expects an address _external_ to the associated CodeBuffer. This might not be the case since "byte map base" /is not/need not be/ a proper address. Instead, the "byte map base" may be materialised as a constant, in order to avoid relocation (issues).
> 
> (If PC-relative materialisation should be used, a new RFE is suggested.)
> 
> Changing assert in "fix_relocation_after_move" to cover both target == NULL and target != NULL, for both source and destination code buffer.

Looks good.

-------------

Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1382


More information about the hotspot-dev mailing list