Integrated: 8243315: ParallelScavengeHeap::initialize() passes GenAlignment as page size to os::trace_page_sizes instead of actual page size
Joakim Nordström
github.com+779991+jaokim at openjdk.java.net
Wed Nov 25 09:40:02 UTC 2020
On Wed, 11 Nov 2020 09:27:50 GMT, Joakim Nordström <github.com+779991+jaokim at openjdk.org> wrote:
> ### Description
> The logging for reserved heap space, printed the `GenAlignment` value instead of page size.
> Before:
> <pre>
> [0.369s][info][gc ] Using Parallel
> [0.374s][info][pagesize] Heap: min=2M max=2M base=0x00000000ffe00000 <b>page_size=512K</b> size=2M
> </pre>
> Besides changing to display page size using `os::vm_page_size()`, this fix also adds logging of `SpaceAlignment `,`GenAlignment`, and `HeapAlignment`.
> After:
> <pre>
> [0.367s][info][pagesize] <b>Alignments: space_align=512K gen_align=512K heap_align=2M</b>
> [0.369s][info][gc ] Using Parallel
> [0.374s][info][pagesize] Heap: min=2M max=2M base=0x00000000ffe00000 <b>page_size=4K</b> size=2M
> </pre>
> Please advice whether the added logging of alignments is sufficient or irrelevant. There were no signs of either alignment being logged anywhere.
> ### Testing
> - Tested manually, and logs are showing with arguments <code>-Xlog:pagesize=info -XX:+UseParallelGC</code>
> - Tested Tier1, Tier2, Tier3.
This pull request has now been integrated.
Changeset: 8cd2e0f6
Author: Joakim Nordström <joakim.nordstrom at oracle.com>
Committer: Stefan Johansson <sjohanss at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/8cd2e0f6
Stats: 144 lines in 7 files changed: 116 ins; 24 del; 4 mod
8243315: ParallelScavengeHeap::initialize() passes GenAlignment as page size to os::trace_page_sizes instead of actual page size
Reviewed-by: sjohanss, tschatzl
-------------
PR: https://git.openjdk.java.net/jdk/pull/1161
More information about the hotspot-dev
mailing list