RFR: 8254042: gtest/GTestWrapper.java failed os.test_random [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Wed Nov 25 17:23:10 UTC 2020
> The function os::init_random() and os::random() both set the _rand_seed. This test thinks nothing can change the seed while it is computing its expected value.
> I changed the test to run in a VM operation safepoint. Alternately, I can change the test to not verify the random value computed in the loop, or remove the test.
> Ran tier1 tests on linux-x64 and windows-x64.
Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
- Restore old copyright
- Refix os.random test using Thomas Stuefe's better suggestion.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1422/files
- new: https://git.openjdk.java.net/jdk/pull/1422/files/7961b368..3292c2f8
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1422&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1422&range=00-01
Stats: 58 lines in 4 files changed: 8 ins; 25 del; 25 mod
Patch: https://git.openjdk.java.net/jdk/pull/1422.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1422/head:pull/1422
PR: https://git.openjdk.java.net/jdk/pull/1422
More information about the hotspot-dev
mailing list