RFR: 8254042: gtest/GTestWrapper.java failed os.test_random [v2]

Kim Barrett kbarrett at openjdk.java.net
Wed Nov 25 23:48:57 UTC 2020


On Wed, 25 Nov 2020 17:23:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The function os::init_random() and os::random() both set the _rand_seed. This test thinks nothing can change the seed while it is computing its expected value.
>> I changed the test to run in a VM operation safepoint.  Alternately, I can change the test to not verify the random value computed in the loop, or remove the test.
>> Ran tier1 tests on linux-x64 and windows-x64.
>
> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Restore old copyright
>  - Refix os.random test using Thomas Stuefe's better suggestion.

Marked as reviewed by kbarrett (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1422


More information about the hotspot-dev mailing list