RFR: 8256382: Use try_lock for hs_err EventLog printing [v2]

David Holmes dholmes at openjdk.java.net
Thu Nov 26 23:15:57 UTC 2020


On Thu, 26 Nov 2020 11:12:57 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8256382_eventlog_try_lock
>>  - 8256382: Use try_lock for hs_err EventLog printing
>
> LGTM

> 
> 
> @tstuefe @dholmes-ora What's the path forward with this PR? Have your reconciled and come to a conclusion about what you want me to change?

I have no particular "wants" in this area I was just trying to evaluate the two proposals. Thomas seems fine with your original proposal now. I thought you were suggesting above you should be using `fatal_error_in_progress()` instead, so I'm not sure if this is your final proposal. If it is then I'm fine with it. There's no perfect solution when it comes to error reporting.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1408


More information about the hotspot-dev mailing list