RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v2]

Thomas Stuefe stuefe at openjdk.java.net
Fri Nov 27 06:29:12 UTC 2020


> To analyze JDK-8256729 further, we need more tracing:
> 
> 1) We should print all mappings inside the split area if os::split_reserved_memory() fails
> 
> 2) The print-mapping code on windows has some shortcomings:
> - should not probe for mappings outside of what we know are valid address ranges for Windows
> - should handle wrap-arounds - it should be possible to print the whole address space
> - Protection information is printed wrong (MEMORY_BASIC_INFORMATION.Protect would be the correct member)
> - should be printed in a more compact manner - base address should be on the same line as the first region
> - maybe adorned with some basic range info, e.g. library mappings

Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge
 - Initial patch

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1390/files
  - new: https://git.openjdk.java.net/jdk/pull/1390/files/7bba557d..71d8ef99

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1390&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1390&range=00-01

  Stats: 13570 lines in 396 files changed: 5223 ins; 2162 del; 6185 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1390.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1390/head:pull/1390

PR: https://git.openjdk.java.net/jdk/pull/1390


More information about the hotspot-dev mailing list