RFR: 8254042: gtest/GTestWrapper.java failed os.test_random [v3]

Coleen Phillimore coleenp at openjdk.java.net
Mon Nov 30 12:54:15 UTC 2020


> The function os::init_random() and os::random() both set the _rand_seed. This test thinks nothing can change the seed while it is computing its expected value.
> I changed the test to run in a VM operation safepoint.  Alternately, I can change the test to not verify the random value computed in the loop, or remove the test.
> Ran tier1 tests on linux-x64 and windows-x64.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Add comment about next_random.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1422/files
  - new: https://git.openjdk.java.net/jdk/pull/1422/files/3292c2f8..ba372ae6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1422&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1422&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1422.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1422/head:pull/1422

PR: https://git.openjdk.java.net/jdk/pull/1422


More information about the hotspot-dev mailing list