RFR: 8253650: Cleanup: remove alignment_hint parameter from os::reserve_memory [v2]

[Thomas Stuefe]

On Thu, 1 Oct 2020 11:50:43 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment fixes
>
> src/hotspot/os/posix/os_posix.cpp line 327:
> 
>> 325:     // Todo: this probably works more out of accident. Using reserve_mmapped_memory would require an munmap
>> 326:     //  to release, but later in this function os::release_memory is used which is not guaranteed to use mmap.
>> 327:     //  See JDK-8253851.
> 
> Looks good apart from these two todo comments (i.e. the TODO:really? one and the last paragraph): they only replicate
> the information you added to JDK-8253851. Source code isn't a good place to track issues, so I would prefer if these
> comments were removed since they seem superfluous. Your call.

Thanks Thomas.

I will remove the TODOs as you requested. As outside contributor I find those remarks very useful to make internal "xxx
works on it" herd knowledge visible. But here I have no strong emotions.

-------------

PR: https://git.openjdk.java.net/jdk/pull/430