RFR: 8253891: Debug x86_32 builds fail after JDK-8239090
Paul Hohensee
phh at openjdk.java.net
Thu Oct 1 13:42:13 UTC 2020
On Thu, 1 Oct 2020 09:52:54 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> `CPU_MAX_FEATURE` is actually a `uint64_t`, with at least 46 bits set. `exact_log2` expects `intptr_t`. The implicit
> conversion works on 64-bit, but fails on 32-bit. Calling to `exact_log2_long` seems to cater for both bitnesses.
> Testing:
> - [x] tier1 on Linux x86_64
> - [x] tier1 on Linux x86_32 (some unrelated failures)
Thanks for cleaning this up.
-------------
Marked as reviewed by phh (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/455
More information about the hotspot-dev
mailing list