RFR: 8253794: TestAbortVMOnSafepointTimeout never timeouts

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Thu Oct 1 19:01:05 UTC 2020


On Thu, 1 Oct 2020 14:35:45 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> The issue is that this test doesn't consider Handshake All operation.
> Depending if/when such operation is scheduled it can lockup the VM thread.
> And the safepoint that should timeout never happens.
> See issue for more information.
> 
> So I changed the test to "try timeout" the safepoint, but if there was no safepoint (blocked by a handshake all), we
> retry. We sleep unsafe much longer than the interval SafepointALot generates operations, which 'guarantees' we will
> timeout if there is no handshake all. (some extreme case of kernel scheduling causing a very long context switch could
> also make us not timeout)  Passes t1, t3, and repeat runs of the test.

LGTM

-------------

Marked as reviewed by pchilanomate (Committer).

PR: https://git.openjdk.java.net/jdk/pull/465


More information about the hotspot-dev mailing list