RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

[David Holmes]

Hi Vladimir,

On 3/10/2020 1:29 am, Vladimir Kempik wrote:
> On Fri, 2 Oct 2020 07:34:45 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:
>>> If you still see no issues here we can delay and make this changeset part of JEP-391.
>>> But since this changeset isn't much macos-aarch64 specific, I thought it would be good to integrate it separately from
>>> jep-391.
>>
>> ... this change actually goes against the example in the spec, so if you
>> make this change it indicates the spec needs to be updated too.
>>
>> Cheers,
>> David
>> -----
> 
> Hello David
> 
> I really believe the problem is in document here ( in examples)
> first, the doc clearly specify the type
> 
> typedef jvmtiError (JNICALL *jvmtiExtensionFunction)
>      (jvmtiEnv* jvmti_env,
>        ...);
> 
> then in examples it declares the function not matching this spec.
> 
> Is it a good idea to update the docs in a separate bug ?

I don't think it really matters one way or the other as long as any new 
bug is promptly fixed. At the moment the code matches the example in the 
spec but they are both "wrong". I'd like to see them both "right" asap.

Thanks,
David

> Thanks, Vladimir
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/466
>