RFR: 8253750: use build-stable default seed for Utils.RANDOM_GENERATOR [v3]
Roger Riggs
rriggs at openjdk.java.net
Tue Oct 6 13:38:09 UTC 2020
On Mon, 5 Oct 2020 23:30:37 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> I was thinking that the code added to Utils.SEED initialization could just have easily been added to
>> RandomFactory.getSystemSeed() and not have to be changed later.
>
> well, `RandomFactory::getSystemSeed` reads `seed` property, while `Utils.SEED` reads `jdk.test.lib.random.seed`, and
> there are tests which use these properties to specify seeds, I'd prefer to leave changing these tests to
> [8212077](https://bugs.openjdk.java.net/browse/JDK-8212077). o/c we can add a new method, e.g.
> `RandomFactory::getBuildStableSeed`, or refactor `RandomFactory::getSystemSeed` to take property name as an argument,
> but I don't think it's really worth it as 8212077 is starting to slowly bubble up in my working queue.
If the factories duplication will get combined/resolved with 8212077, I'll leave that up to you.
-------------
PR: https://git.openjdk.java.net/jdk/pull/391
More information about the hotspot-dev
mailing list